4400 remove hardcoded bc20m and tc0m by chris-ashe · Pull Request #4478 · ukaea/PROCESS

chris-ashe · 2026-07-27T09:38:36Z

Description

Checklist

I confirm that I have completed the following checks:

My changes follow the PROCESS style guide
I have justified any large differences in the regression tests caused by this pull request in the comments.
I have added new tests where appropriate for the changes I have made.
If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
If I have made documentation changes, I have checked they render correctly.
I have added documentation for my change, if appropriate.

codecov-commenter · 2026-07-27T09:56:40Z

Codecov Report

❌ Patch coverage is 36.76471% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (c0ae5b2) to head (4b59b1e).

Files with missing lines	Patch %	Lines
process/models/stellarator/coils/coils.py	4.54%	21 Missing ⚠️
process/models/tfcoil/superconducting.py	29.41%	12 Missing ⚠️
process/models/pfcoil.py	42.85%	8 Missing ⚠️
process/models/superconductors.py	86.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4478      +/-   ##
==========================================
- Coverage   49.32%   49.32%   -0.01%     
==========================================
  Files         150      150              
  Lines       29802    29811       +9     
==========================================
+ Hits        14700    14703       +3     
- Misses      15102    15108       +6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

clmould

A few small things

clmould

1 tiny thing

clmould

Found a few remaining hard-coded values to be updated to use the SuperconductorModel values instead. Also 2 more things:

There are some hard coded values in documentation/plotting_scripts - could these be updated to use the SuperconductorModel too please?

Also one instance of jcrit_rebco needs the new args adding still in 2nd_gen_rebco_critical_surface.py (can they be done as keyword args please):

clmould

In documentation/scripts/plotting_scripts/old_empirical_nbti_critical_surface.py, can the args b_c20max and temp_c0max in jcrit_nbti() use the SuperconductorModel please:

clmould · 2026-08-13T12:03:35Z

        SuperconductorShape.CABLE,
        "Old Lubell NbTi",
    )
    USER_DEFINED_NB3SN = (


Could you add a warning message/check somewhere that if bcritsc and/or tcritsc are input but i_tf_sc_mat != 4 that it warns the user they tried to input these params but they have selected a different material so it's not using their inputs for the temp and field

…e parameters for improved flexibility

…SuperconductorModel

…field and temperature

… replacing them with dynamic properties from SuperconductorModel

…them with dynamic properties from SuperconductorModel

Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

… temperature values for REBCO

… temperature values

…namic values from SuperconductorModel

…ductorModel

…rface.py Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

…surface.py Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

…rModel parameters

Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

chris-ashe added TF Coil Toroidal field coil PF Coils CS Coil labels Jul 27, 2026

chris-ashe linked an issue Jul 27, 2026 that may be closed by this pull request

Remove hardcoded bc20m and tc0m #4400

Open

chris-ashe added Refactor Superconductors labels Jul 27, 2026

chris-ashe requested a review from clmould July 27, 2026 10:09

chris-ashe marked this pull request as ready for review July 27, 2026 10:09

chris-ashe requested a review from a team as a code owner July 27, 2026 10:09

clmould requested changes Jul 28, 2026

View reviewed changes

Comment thread process/models/superconductors.py Outdated

Comment thread process/models/superconductors.py Outdated

Comment thread process/models/stellarator/coils/coils.py Outdated

Comment thread process/models/stellarator/coils/coils.py Outdated

chris-ashe requested a review from clmould July 28, 2026 13:46

clmould requested changes Jul 28, 2026

View reviewed changes

Comment thread process/models/superconductors.py Outdated

clmould self-assigned this Jul 28, 2026

chris-ashe requested a review from clmould August 11, 2026 13:00

clmould requested changes Aug 12, 2026

View reviewed changes

Comment thread tests/unit/models/test_superconductors.py Outdated

Comment thread process/models/superconductors.py

Comment thread tests/unit/models/tfcoil/test_sctfcoil.py

Comment thread process/models/stellarator/coils/coils.py Outdated

Comment thread tests/unit/models/test_superconductors.py

chris-ashe requested a review from clmould August 12, 2026 14:53

chris-ashe force-pushed the 4400-remove-hardcoded-bc20m-and-tc0m branch from 32d48ff to fef6f55 Compare August 12, 2026 15:08

clmould requested changes Aug 12, 2026

View reviewed changes

je-cook requested a review from a team August 13, 2026 07:23

chris-ashe requested review from clmould and removed request for a team August 13, 2026 08:40

clmould requested changes Aug 13, 2026

View reviewed changes

chris-ashe force-pushed the 4400-remove-hardcoded-bc20m-and-tc0m branch 2 times, most recently from 3df6d11 to 3e90a55 Compare August 14, 2026 09:57

chris-ashe added 5 commits August 14, 2026 16:06

Refactor SuperconductorModel to include critical field and temperatur…

0ebee1e

…e parameters for improved flexibility

Replace hardcoded bc20m and tc0m values with dynamic properties from …

f4bff95

…SuperconductorModel

Replace hardcoded bc20m and tc0m values with dynamic properties from …

8cff8db

…SuperconductorModel

Update Durham NbTi parameters to use defined properties for critical …

6de7dcf

…field and temperature

Remove hardcoded bc20m and tc0m values from PFCoil and CSCoil models,…

ce6b906

… replacing them with dynamic properties from SuperconductorModel

chris-ashe and others added 16 commits August 14, 2026 16:06

Remove hardcoded b_crit_upper_nbti and t_crit_nbti values, replacing …

a9a2b8b

…them with dynamic properties from SuperconductorModel

Update process/models/superconductors.py

af1c782

Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

Requested changes

5c9f7d9

Refactor CROCOSuperconductingTFCoil to use dynamic critical field and…

a879dc4

… temperature values for REBCO

Refactor REBCO superconductor model to use dynamic critical field and…

72b889a

… temperature values

Refactor tests to replace hardcoded bc20max and tc0max values with dy…

049a3c2

…namic values from SuperconductorModel

Refactor jcrit_from_material to use named parameters for clarity

605a6f3

Refactor critical surface scripts to use dynamic values from Supercon…

1fef638

…ductorModel

Removed wrongly added due to rebase, HTS tapes in CICC class

19e1d15

Update documentation/scripts/plotting_scripts/eutf4_nb3sn_critical_su…

cd2bce7

…rface.py Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

Update documentation/scripts/plotting_scripts/western_nb3sn_critical_…

1fabe57

…surface.py Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

Update documentation/scripts/plotting_scripts/2nd_gen_rebco_critical_…

caca5fa

…surface.py Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

Update documentation/scripts/plotting_scripts/western_nb3sn_critical_…

e879428

…surface.py Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

Refactor: Replace hardcoded b_c20m and tc0m values with Superconducto…

eeb9420

…rModel parameters

Update tests/unit/models/tfcoil/test_sctfcoil.py

a867b50

Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

Update tests/unit/models/tfcoil/test_sctfcoil.py

4b59b1e

Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>

chris-ashe force-pushed the 4400-remove-hardcoded-bc20m-and-tc0m branch from 3e90a55 to 4b59b1e Compare August 14, 2026 15:06

Uh oh!

Conversation

chris-ashe commented Jul 27, 2026

Description

Checklist

Uh oh!

codecov-commenter commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

clmould left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clmould left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clmould left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clmould left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clmould Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Jul 27, 2026 •

edited

Loading