Skip to content

Re-remove accidentally readded exit conditions - #4524

Merged
je-cook merged 3 commits into
ukaea:mainfrom
je-cook:clean_solver
Aug 14, 2026
Merged

Re-remove accidentally readded exit conditions#4524
je-cook merged 3 commits into
ukaea:mainfrom
je-cook:clean_solver

Conversation

@je-cook

@je-cook je-cook commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Description

I accidentally readded these in #4508, I also obviously messed up the rebase...added some more changes to solver that I meant to pull over from #4308

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@je-cook
je-cook requested a review from a team as a code owner August 14, 2026 08:07
@je-cook je-cook added the Core label Aug 14, 2026
@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.31%. Comparing base (8fe9306) to head (56a703c).

Files with missing lines Patch % Lines
process/core/solver/solver_handler.py 17.64% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4524      +/-   ##
==========================================
+ Coverage   49.30%   49.31%   +0.01%     
==========================================
  Files         150      150              
  Lines       29769    29769              
==========================================
+ Hits        14679    14682       +3     
+ Misses      15090    15087       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/core/solver/solver_handler.py Outdated
@je-cook
je-cook merged commit d353420 into ukaea:main Aug 14, 2026
11 checks passed
@je-cook
je-cook deleted the clean_solver branch August 14, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants