BCs in kinetic SOL-KiT thesis example - #72
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-v2.0.1 #72 +/- ##
===========================================
Coverage 88.71% 88.71%
===========================================
Files 33 33
Lines 7603 7603
===========================================
Hits 6744 6744
Misses 859 859 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sleigh2022
previously requested changes
Jun 11, 2026
sleigh2022
left a comment
sleigh2022
left a comment
Collaborator
There was a problem hiding this comment.
Hi, requesting the following changes be made before approval:
- Repeat the edits to the solkit fluid example
- Change the destination branch from
mastertodev-v2.0.1.
sleigh2022
self-requested a review
August 11, 2026 12:12
sleigh2022
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed ion speed in BCs from$u_i$ to $c_s$