Skip to content

tests(native): subgraph and capture#70

Merged
romintomasetti merged 1 commit into
mainfrom
subgraph-capture
Nov 15, 2024
Merged

tests(native): subgraph and capture#70
romintomasetti merged 1 commit into
mainfrom
subgraph-capture

Conversation

@romintomasetti

Copy link
Copy Markdown
Collaborator

Summary

This PR further explores graph capture.

We try to get closer to an external library call, wherein some state variables are created and need to be kept alive until the graph is destroyed.

@romintomasetti romintomasetti self-assigned this Nov 6, 2024
@romintomasetti romintomasetti force-pushed the subgraph-capture branch 2 times, most recently from 57b8797 to d63755b Compare November 7, 2024 08:23
Comment thread tests/cuda/test_graph_capture.cpp Outdated
@romintomasetti romintomasetti changed the title Subgraph capture tests(cuda): subgraph and capture Nov 12, 2024
@romintomasetti romintomasetti changed the title tests(cuda): subgraph and capture tests(native): subgraph and capture Nov 14, 2024
Comment thread tests/cuda/test_graph_capture.cpp Outdated
Comment thread tests/cuda/test_graph_capture.cpp Outdated
Comment thread tests/native/test_graph_capture.cpp
@romintomasetti romintomasetti force-pushed the subgraph-capture branch 4 times, most recently from eaa5deb to d020eb6 Compare November 14, 2024 17:20
@romintomasetti romintomasetti marked this pull request as ready for review November 14, 2024 17:41
Comment thread tests/native/APIWrappers_def.hpp Outdated
Comment thread tests/native/test_graph_capture.cpp
@maartenarnst

Copy link
Copy Markdown
Collaborator

The cuda toolkit documentation says that cudaGraphAddChildGraphNode returns an error if the graph contains memory nodes. This may be an issue with the approach of adding the result of the capture as a child graph node. Probably worth looking into more.

@romintomasetti romintomasetti left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@romintomasetti romintomasetti merged commit f3d3384 into main Nov 15, 2024
@romintomasetti romintomasetti deleted the subgraph-capture branch November 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants