Skip to content

feat(core): dialogs should run out of command line#403

Merged
calebjclark merged 3 commits intomainfrom
oob
Dec 20, 2021
Merged

feat(core): dialogs should run out of command line#403
calebjclark merged 3 commits intomainfrom
oob

Conversation

@blakebyrnes
Copy link
Contributor

@blakebyrnes blakebyrnes commented Dec 16, 2021

This PR introduces two small, but potentially impactful changes:

  1. The "waitForReady" state inside core is changed from DomContentLoaded to HttpResponded for the current resource. It seems like a potentially expensive condition to impose on some sites that take a long time to load.

NOTE: I kept interact and execJsPath as requiring DomContentLoaded before running. Things seemed fragile in our tests without it, which made me question when you'd really not want it for those two. Up for conversation about this.

  1. Two core commands are now going to "bypass" the coreCommandQueue "line" and run outside the regular queue: getResourceProperty and dismissDialog. Both are used inside event listeners, and in the case of getResourceProperty, it can't really impact the flow of the script

This PR also integrates "willDismissDialog" into the interaction so that it can provide an optional wait. The default human emulator has a small wait before dismissing.

Closes #397

@blakebyrnes blakebyrnes mentioned this pull request Dec 17, 2021
@calebjclark calebjclark merged commit 05f7132 into main Dec 20, 2021
@calebjclark calebjclark deleted the oob branch December 20, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with Dialog

2 participants