fix: Return nil if negative time elapsed from last block happens

[RafilxTenfen]

Description

Implemented Option 3: Modify AccrueAllInterest to treat "negative time elapsed" as "zero time elapsed", aborting the function without modifying the state until an EndBlock where BlockTime > LastInterestTime.

closes: #543

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added appropriate labels to the PR
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov-commenter]

Codecov Report

Merging #1018 (dc77869) into main (bd2244f) will decrease coverage by 0.08%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   43.96%   43.87%   -0.09%     
==========================================
  Files          64       64              
  Lines        8332     8335       +3     
==========================================
- Hits         3663     3657       -6     
- Misses       4414     4422       +8     
- Partials      255      256       +1     

Impacted Files	Coverage Δ
x/leverage/keeper/interest.go	72.97% <15.38%> (-5.65%)	⬇️

[robert-zaremba]

Log is not enough. I think we should either return some message or keep the error.

[RafilxTenfen]

What do you think about these options? @robert-zaremba

[robert-zaremba]

IMHO, we should fix the genesis logic rather than handling it here. Let's continue at: #543 (comment)

[robert-zaremba]

OK

[robert-zaremba]

Don't want to block this PR, but I don't think this is the right way for handling the issue.
Side note: issuing Error log without returning error smells bad.

[robert-zaremba]

IMHO, we should fix the genesis logic rather than handling it here. Let's continue at: #543 (comment)

[RafilxTenfen]

@robert-zaremba So, do you think we should change from Error to Warn?

[RafilxTenfen]

@robert-zaremba So, do you think we should change from Error to Warn?

There is no Warn in Tendermin Logger

Only [Debug,Info, Error]

[toteki]

Message can keep Error log level for now. Once tendermint fixes, we can return ErrNegativeTimeElapsed instead of nil, which would bring it back to causing chain halt (which we want in this case).

[robert-zaremba]

OK