feat!: allow amount-specific control of collateral#1029
Conversation
|
Couple tweaks to the sim tests still needed |
Codecov Report
@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
+ Coverage 43.31% 43.72% +0.40%
==========================================
Files 65 65
Lines 8381 8298 -83
==========================================
- Hits 3630 3628 -2
+ Misses 4502 4421 -81
Partials 249 249
|
|
The protobuf / breakage is expected to fail? |
Yeah, this breaks the API of |
|
So, right now if someone has already supplied 1k token and set 1k as collateral |
Yeah, if this merges they'll need to do an additional |
robert-zaremba
left a comment
There was a problem hiding this comment.
- Please add more details to the changelog
- overall good work, nice to see general code reduction (diff is negative) 👍
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
robert-zaremba
left a comment
There was a problem hiding this comment.
utACK
- please add few comments to the proto
- this PR can't be backported to v2.x - it's breaking
Description
Removes true/false collateral settings.
Instead, users add or remove exact amounts of uTokens as collateral.
This will allow more fine-grained control, helping advanced users as well as possibly preparing us for more advanced liquidity pool design.
Closes #904
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change