Conversation
toteki
commented
Jul 5, 2022
toteki
commented
Jul 5, 2022
toteki
commented
Jul 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 43.54% 43.54%
=======================================
Files 65 65
Lines 8336 8336
=======================================
Hits 3630 3630
Misses 4456 4456
Partials 250 250
|
toteki
commented
Jul 5, 2022
toteki
commented
Jul 5, 2022
Contributor
Author
toteki
left a comment
There was a problem hiding this comment.
Massive diff - just finished combing through the files manually.
The other proto rename PRs won't be like this. This one requires a change in vocabulary in the docs.
robert-zaremba
approved these changes
Jul 5, 2022
Contributor
robert-zaremba
left a comment
There was a problem hiding this comment.
Approving, but left some comments and suggestions (could be applied to other places).
Moreover in some place we should add more context because supply is very general (eg: "for lending or collateral")
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of renaming here - the word "lend" no longer appears except in old changelogs and the phrase "lending pool".
The major API breaks:
MsgLendAsset->MsgSupplyQueryLoaned->QuerySupplied(and total loaned, other queries)LendAPY->SupplyAPYLender->Supplierfield in some placesIf looking for API breaking changes, view the proto file diffs first.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...