chore!: remove request suffix from leverage and oracle queries#1123
Merged
chore!: remove request suffix from leverage and oracle queries#1123
Conversation
toteki
changed the title
toteki
commented
Jul 11, 2022
Contributor
Author
toteki
left a comment
toteki
left a comment
There was a problem hiding this comment.
Diff is only renaming here
Codecov Report
@@ Coverage Diff @@
## main #1123 +/- ##
=======================================
Coverage 43.82% 43.82%
=======================================
Files 65 65
Lines 8393 8393
=======================================
Hits 3678 3678
Misses 4472 4472
Partials 243 243
|
Contributor
|
should we do the same for oracle package in another PR? |
RafilxTenfen
approved these changes
Jul 11, 2022
Contributor
Author
If @WoZ is good with it, I can add oracle queries to this PR |
toteki
changed the title
adamewozniak
approved these changes
Jul 11, 2022
Collaborator
adamewozniak
left a comment
adamewozniak
left a comment
There was a problem hiding this comment.
Lgtm! Thanks for doing this in oracle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Query...RequesttoQuery...for all queries in the leverage module.Note @adamewozniak: Oracle proto has been modified as well.
closes: #1104
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.md