Merged
Conversation
RafilxTenfen
approved these changes
Jul 12, 2022
adamewozniak
approved these changes
Jul 12, 2022
Contributor
|
Does this need to go to changelogs? |
toteki
approved these changes
Jul 12, 2022
Contributor
|
No changelog needed in my opinion since observable behavior is unaffected |
Contributor
Author
|
I will add changelog update |
Contributor
|
I added labels and changed type prefix to |
Contributor
Author
|
Thanks for quick review! |
Contributor
Author
We don't need to add labels in PRs linked to issues. If PR is not linked to issue, then we can use it as a "task" by adding to a board - only then we need to add labels.
Thanks, makes sense. |
Codecov Report
@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 43.82% 43.82%
=======================================
Files 65 65
Lines 8393 8393
=======================================
Hits 3678 3678
Misses 4472 4472
Partials 243 243
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #1114
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...