Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
+ Coverage 50.53% 52.20% +1.67%
==========================================
Files 67 67
Lines 6831 6827 -4
==========================================
+ Hits 3452 3564 +112
+ Misses 3135 3000 -135
- Partials 244 263 +19
|
toteki
reviewed
Aug 10, 2022
toteki
reviewed
Aug 10, 2022
toteki
reviewed
Aug 10, 2022
toteki
suggested changes
Aug 11, 2022
Contributor
toteki
left a comment
toteki
left a comment
There was a problem hiding this comment.
The style changes could be considered but this PR contains erroneous behavior changes.
I need to add better MsgLiquidate tests in keeper_test.go to catch this kind of thing - specifically devations from what the function says it did (in return values) and actual changes to borrowed, collateral, and account+balances.
Contributor
Author
|
+1 for tests, thanks for review |
toteki
reviewed
Aug 12, 2022
toteki
reviewed
Aug 12, 2022
Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
Contributor
Author
|
Up, calling for review and unblock. |
toteki
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1222
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...