Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
- Coverage 52.09% 52.09% -0.01%
==========================================
Files 69 69
Lines 6816 6828 +12
==========================================
+ Hits 3551 3557 +6
- Misses 2988 2992 +4
- Partials 277 279 +2
|
Contributor
Author
|
Note: this will stay draft while we decide if Edit: R4R - keeping the simple version for v3 |
RafilxTenfen
approved these changes
Sep 6, 2022
4 tasks
robert-zaremba
suggested changes
Sep 6, 2022
Contributor
robert-zaremba
left a comment
robert-zaremba
left a comment
There was a problem hiding this comment.
Let's use share value with a minimum total collateral to trigger the limitation (can be hardcoded in v3 as 500k I would say - in other words, the MaxSupply check will be triggered only if TotalAllSuply is >= 500k USD)
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
robert-zaremba
approved these changes
Sep 6, 2022
Contributor
robert-zaremba
left a comment
robert-zaremba
left a comment
There was a problem hiding this comment.
Following our discussion, we won't use that functionality. We can:
- leave this PR in draft
- or merge and add appropriate comments in the code
Do as you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements one of the token safety parameters on the leverage checklist.
closes: #1227
Author Checklist
!to the type prefix if API or client breaking changeCHANGELOG.md