Conversation
Codecov Report
@@ Coverage Diff @@
## main #1329 +/- ##
==========================================
- Coverage 51.86% 51.85% -0.02%
==========================================
Files 68 69 +1
Lines 6677 6754 +77
==========================================
+ Hits 3463 3502 +39
- Misses 2947 2979 +32
- Partials 267 273 +6
|
This was referenced Sep 5, 2022
RafilxTenfen
approved these changes
Sep 6, 2022
robert-zaremba
suggested changes
Sep 6, 2022
Contributor
robert-zaremba
left a comment
There was a problem hiding this comment.
We decided to implement MaxCollateralShare as a % value
4 tasks
Contributor
robert-zaremba
left a comment
There was a problem hiding this comment.
overall looks good. Let's don't calculate GetTotalCollateral twice.
4 tasks
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
robert-zaremba
approved these changes
Sep 6, 2022
Contributor
robert-zaremba
left a comment
There was a problem hiding this comment.
pre-approving. Please look at the comments.
This was referenced Apr 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #1093
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...