Skip to content

feat: add leverage/Params.max_share_trigger proto#1409

Closed
robert-zaremba wants to merge 4 commits intomainfrom
robert/share-trigger
Closed

feat: add leverage/Params.max_share_trigger proto#1409
robert-zaremba wants to merge 4 commits intomainfrom
robert/share-trigger

Conversation

@robert-zaremba
Copy link
Copy Markdown
Contributor

Description

We need a leverage module parameter to solve a cold start / bootstrap problem for tokens with limited max_supply and max_collateral_share.

Ref:


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added this to the v3 milestone Sep 18, 2022
@robert-zaremba robert-zaremba requested review from a team as code owners September 18, 2022 11:43
// is below `max_share_trigger`, the limitation is not checked.
// Valule in USD. 1 = 1 USD
// Valid values: 1-∞
uint64 max_share_trigger = 1 [
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 was not used.
Open for suggestions for a better name for this param.

@toteki
Copy link
Copy Markdown
Contributor

toteki commented Sep 18, 2022

This should wait until v4, as it is not required for mainnet release.

@toteki toteki modified the milestones: v3, v4 Sep 18, 2022
@adamewozniak
Copy link
Copy Markdown
Collaborator

This should wait until v4, as it is not required for mainnet release.

agreed

@robert-zaremba
Copy link
Copy Markdown
Contributor Author

@adamewozniak , @toteki I prefer to have stable proto. This PR doesn't add new functionality. But we will need to use it as soon as we will enable Axelar.
Also, see: https://umeeworkspace.slack.com/archives/C03CVS0459A/p1663499718056569

@stale
Copy link
Copy Markdown

stale bot commented Oct 19, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Oct 19, 2022
@stale stale bot closed this Oct 26, 2022
@robert-zaremba robert-zaremba reopened this Nov 4, 2022
@stale stale bot removed the S:Stale label Nov 4, 2022
@robert-zaremba
Copy link
Copy Markdown
Contributor Author

I'm going to extract the docs imprvements from this PR and move it to a new PR.

@stale
Copy link
Copy Markdown

stale bot commented Dec 4, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Dec 4, 2022
@stale
Copy link
Copy Markdown

stale bot commented Jan 21, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Jan 21, 2023
@stale
Copy link
Copy Markdown

stale bot commented Feb 24, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the S:Stale label Feb 24, 2023
@stale stale bot closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants