Skip to content

feat: add MsgSupplyCollateral#1479

Merged
mergify[bot] merged 9 commits intomainfrom
adam/supplycollateral
Oct 7, 2022
Merged

feat: add MsgSupplyCollateral#1479
mergify[bot] merged 9 commits intomainfrom
adam/supplycollateral

Conversation

@toteki
Copy link
Copy Markdown
Contributor

@toteki toteki commented Oct 6, 2022

This might or might not be okay to merge in a minor version (due to adding a message type). Supports a common frontend use case.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki
Copy link
Copy Markdown
Contributor Author

toteki commented Oct 6, 2022

This PR should be evaluated for inclusion in v3.1.0

@toteki toteki marked this pull request as ready for review October 6, 2022 22:54
@toteki toteki requested review from a team as code owners October 6, 2022 22:54
Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it. API, especially on proto level, should not have redundancy when possible.
The same effect can be achieved with one transaction with multiple messages.

@robert-zaremba
Copy link
Copy Markdown
Contributor

this could have unintended consequences if we feed them into MsgServer (I'm not 100% sure).

You don't go through MsgServer, and no need to check signatures. You directly call the handler.
In fact even if you would go through MsgServer (which is not clearly supported today), it won't check signatures nor call ValidateBasic (which is happening at different stage)

Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. See #1479 (comment) . That would be my preference, but I'm not against using the current way. I just prefer to avoid possible duplications.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1479 (41e932a) into main (4519faf) will decrease coverage by 0.50%.
The diff coverage is 13.95%.

❗ Current head 41e932a differs from pull request most recent head 55a5d3e. Consider uploading reports for the commit 55a5d3e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1479      +/-   ##
==========================================
- Coverage   52.75%   52.25%   -0.51%     
==========================================
  Files          71       71              
  Lines        6750     6834      +84     
==========================================
+ Hits         3561     3571      +10     
- Misses       2920     2994      +74     
  Partials      269      269              
Impacted Files Coverage Δ
x/leverage/client/cli/tx.go 0.00% <0.00%> (ø)
x/leverage/keeper/msg_server.go 0.95% <0.00%> (-0.22%) ⬇️
x/leverage/types/tx.go 0.00% <0.00%> (ø)
x/leverage/client/tests/tests.go 100.00% <100.00%> (ø)

@mergify mergify bot merged commit 97c357e into main Oct 7, 2022
@mergify mergify bot deleted the adam/supplycollateral branch October 7, 2022 00:58
mergify bot pushed a commit that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants