Conversation
|
This PR should be evaluated for inclusion in |
robert-zaremba
left a comment
There was a problem hiding this comment.
I don't think we need it. API, especially on proto level, should not have redundancy when possible.
The same effect can be achieved with one transaction with multiple messages.
You don't go through MsgServer, and no need to check signatures. You directly call the handler. |
robert-zaremba
left a comment
There was a problem hiding this comment.
pre-approving. See #1479 (comment) . That would be my preference, but I'm not against using the current way. I just prefer to avoid possible duplications.
Codecov Report
@@ Coverage Diff @@
## main #1479 +/- ##
==========================================
- Coverage 52.75% 52.25% -0.51%
==========================================
Files 71 71
Lines 6750 6834 +84
==========================================
+ Hits 3561 3571 +10
- Misses 2920 2994 +74
Partials 269 269
|
This might or might not be okay to merge in a minor version (due to adding a message type). Supports a common frontend use case.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...