Skip to content

fix: Dragonberry patch#1501

Merged
mergify[bot] merged 11 commits intomainfrom
robert/dragonberry-fix
Oct 21, 2022
Merged

fix: Dragonberry patch#1501
mergify[bot] merged 11 commits intomainfrom
robert/dragonberry-fix

Conversation

@robert-zaremba
Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba commented Oct 14, 2022

Description

Applying Dragonberry fix for v3.1.x


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba marked this pull request as ready for review October 17, 2022 15:23
@robert-zaremba robert-zaremba requested review from a team as code owners October 17, 2022 15:23
@toteki
Copy link
Copy Markdown
Contributor

toteki commented Oct 17, 2022

Check the build+test failures - we need to fix a few things

@toteki
Copy link
Copy Markdown
Contributor

toteki commented Oct 17, 2022

Could this be unintentionally picking up a few changes from 0.46.2 -> 0.46.3 that aren't dragonberry related?

Copy link
Copy Markdown
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need nodeservice on this, maybe removed if is not strictly needed?

@robert-zaremba
Copy link
Copy Markdown
Contributor Author

Extracted it to #1513 - once it will be merged, it will cancel in this PR.

@robert-zaremba
Copy link
Copy Markdown
Contributor Author

Seams this PR must be merged first, I'm reverting the new query service PR.

@robert-zaremba
Copy link
Copy Markdown
Contributor Author

Could this be unintentionally picking up a few changes from 0.46.2 -> 0.46.3 that aren't dragonberry related?

I think that was related to price feeder missing the update. I've updated go.mod in price feeder and it worked afterwords.

@mergify mergify bot merged commit f82e483 into main Oct 21, 2022
@mergify mergify bot deleted the robert/dragonberry-fix branch October 21, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants