Merged
Conversation
Contributor
|
Check the build+test failures - we need to fix a few things |
Contributor
|
Could this be unintentionally picking up a few changes from |
RafilxTenfen
approved these changes
Oct 21, 2022
Contributor
RafilxTenfen
left a comment
There was a problem hiding this comment.
Not sure why we need nodeservice on this, maybe removed if is not strictly needed?
Contributor
Author
|
Extracted it to #1513 - once it will be merged, it will cancel in this PR. |
17 tasks
This reverts commit dec45ee.
Contributor
Author
|
Seams this PR must be merged first, I'm reverting the new query service PR. |
Contributor
Author
I think that was related to price feeder missing the update. I've updated go.mod in price feeder and it worked afterwords. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Applying Dragonberry fix for v3.1.x
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...