feat!: cosmwasm an optional integration to app#1547
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
- Coverage 51.79% 51.59% -0.20%
==========================================
Files 71 71
Lines 6897 6923 +26
==========================================
Hits 3572 3572
- Misses 3056 3081 +25
- Partials 269 270 +1
|
all modules verified --> Installing... go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=umee -X github.com/cosmos/cosmos-sdk/version.AppName=umeed -X github.com/cosmos/cosmos-sdk/version.Version=sai/cosmwasm-c1f6f1f3e9322bf2c110a999dcc42bc07e6d673a -X github.com/cosmos/cosmos-sdk/version.Commit=c1f6f1f3e9322bf2c110a999dcc42bc07e6d673a -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.34.22 -X github.com/umee-network/umee/v3/x/leverage/keeper.EnableLiquidator=false' ./...
robert-zaremba
left a comment
There was a problem hiding this comment.
Left few comments.
Also, have an idea how to better integrate the experimental build without doing so many custom functions. I will make a commit with an example directly in your repo, let me know what do you think.
|
See this commit as an alternative idea to reduce copied functions: 009f87d |
I think it is better to keep old functions only, because we already passing one build flag for |
There is no need for a new flag. Where did you get an impression that we need a new flag?
On the other hand, the code is a bit more bloated. So my idea was to use both: "if else" when the change is small, and function in other places. Especially the |
|
@robert-zaremba Please can you review again |
robert-zaremba
left a comment
There was a problem hiding this comment.
Looks good, let's solve the remaining comments.
Description
added cosmwasm feature as an optional features for app
closes: #802
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...