feat: Add keeper methods for historacle prices and medians#1548
feat: Add keeper methods for historacle prices and medians#1548rbajollari merged 33 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 51.59% 52.18% +0.59%
==========================================
Files 71 72 +1
Lines 6923 7111 +188
==========================================
+ Hits 3572 3711 +139
- Misses 3081 3126 +45
- Partials 270 274 +4
|
adamewozniak
left a comment
There was a problem hiding this comment.
initial review - great job @rbajollari !!
robert-zaremba
left a comment
There was a problem hiding this comment.
Blocking because:
- adding historical price is super inefficient (see comment)
- have concerns about state bloat: how the state will be managed and cleaned?
- why do we have one big median? Shouldn't we have median per "epoch"?
Is there any spec clarifying the pruning functionality? If not, I can help with that if needed.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
adamewozniak
left a comment
There was a problem hiding this comment.
this looks good to me, just a few comments.
I'd like to have a review from @zarazan , and maybe @toteki or @RafilxTenfen as well 🙏
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
dismissing in the interest of time - this lgtm, we still have to figure out how to separate this in the build process (in another PR)
|
waiting for a review from @RafilxTenfen to merge 🙏 |
RafilxTenfen
left a comment
There was a problem hiding this comment.
Just one comment
utACK 💯
Description
closes: #1540
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...