chore!: refactore store key constructors#1578
Merged
mergify[bot] merged 14 commits intomainfrom Nov 12, 2022
Merged
Conversation
robert-zaremba
changed the title
Contributor
|
Hold on before merging this - I want to test it against mainnet store |
toteki
reviewed
Nov 11, 2022
toteki
reviewed
Nov 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
+ Coverage 52.08% 52.47% +0.38%
==========================================
Files 72 73 +1
Lines 7092 7040 -52
==========================================
Hits 3694 3694
+ Misses 3125 3073 -52
Partials 273 273
|
toteki
approved these changes
Nov 11, 2022
Contributor
toteki
left a comment
toteki
left a comment
There was a problem hiding this comment.
Looks good - also I added some leverage key_test.go cases.
toteki
reviewed
Nov 11, 2022
Contributor
Author
Thank you. |
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
robert-zaremba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #1573
Cleanup store key prefix functions.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...