Conversation
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
==========================================
+ Coverage 55.15% 55.29% +0.13%
==========================================
Files 73 73
Lines 7522 7503 -19
==========================================
Hits 4149 4149
+ Misses 3053 3034 -19
Partials 320 320
|
gsk967
reviewed
Dec 12, 2022
gsk967
requested changes
Dec 12, 2022
Collaborator
gsk967
left a comment
gsk967
left a comment
There was a problem hiding this comment.
Can you implement Route and Type methods for all messages , For Ledger support we need to implement this two methods
// Route implements the sdk.Msg interface.
func (m MsgType) Route() string { return types.RouterKey }
// Type implements the sdk.Msg interface.
func (m MsgType) Type() string { return sdk.MsgTypeURL(&m) }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements
Msginterface for the incentive message types and also takes care of some supporting details (codec, errors, etc)It also moves
validateProposalused in leverage toutil/checkers, then reuses it for incentive proposals.Some
make proto-alleffects are also included (oracle formatting / swagger)