Conversation
Codecov Report
@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 55.05% 57.82% +2.76%
==========================================
Files 73 73
Lines 7523 7587 +64
==========================================
+ Hits 4142 4387 +245
+ Misses 3053 2857 -196
- Partials 328 343 +15
|
|
@toteki would you like a review here? Is it just in draft because we haven't cut v3.3 yet? |
|
@adamewozniak I've got a massive diff locally on the unit tests that I need to finish first - then a few other things to clean up (modify Also some new queries (as opposed to modified above) will be a separate PR |
robert-zaremba
left a comment
There was a problem hiding this comment.
thanks for adding tests. I suggest to make them more readable by breaking down repeated code into reusable functions.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
|
Extracted style comments to new issue |
robert-zaremba
left a comment
There was a problem hiding this comment.
utACK. The main change is here: https://github.com/umee-network/umee/pull/1654/files#diff-9257a67f3050fe241bb803e3f669921d63c9091d7fe50d3c243d5bf255d96c7aR21
Minimum tests have been added to cover the historacle case.
We discussed to add more unit tests as well as reduce code duplication in tests in a followup PR.
Description
Ensure that every
MsgBorrow,MsgDecollateralize, andMsgWithdrawis valid under both current and recent historacle prices.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...