Skip to content

fix: add amino support for MsgMaxWithdraw#1680

Merged
toteki merged 2 commits intomainfrom
adam/legacysign
Dec 30, 2022
Merged

fix: add amino support for MsgMaxWithdraw#1680
toteki merged 2 commits intomainfrom
adam/legacysign

Conversation

@toteki
Copy link
Copy Markdown
Contributor

@toteki toteki commented Dec 29, 2022

This is required for ledger signing - and for our Kepler integration, which uses amino (for all users) to support ledgers.

@toteki toteki requested review from a team as code owners December 29, 2022 18:53
Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1680 (09ec03a) into main (be0b601) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   55.05%   55.05%   -0.01%     
==========================================
  Files          73       73              
  Lines        7523     7525       +2     
==========================================
+ Hits         4142     4143       +1     
- Misses       3053     3054       +1     
  Partials      328      328              
Impacted Files Coverage Δ
x/leverage/types/codec.go 41.66% <50.00%> (+0.49%) ⬆️

@toteki toteki merged commit 72438d4 into main Dec 30, 2022
@toteki toteki deleted the adam/legacysign branch December 30, 2022 03:00
@toteki toteki mentioned this pull request Jan 5, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants