feat!: MaxBorrow query and modify MaxWithdraw to return all denoms#1683
Merged
mergify[bot] merged 12 commits intomainfrom Jan 5, 2023
Merged
feat!: MaxBorrow query and modify MaxWithdraw to return all denoms#1683mergify[bot] merged 12 commits intomainfrom
mergify[bot] merged 12 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
+ Coverage 57.82% 57.97% +0.15%
==========================================
Files 73 73
Lines 7589 7821 +232
==========================================
+ Hits 4388 4534 +146
- Misses 2858 2934 +76
- Partials 343 353 +10
|
Contributor
robert-zaremba
left a comment
There was a problem hiding this comment.
- Let's simplify and merge
All*queries by making the denom optional and always returning a list. - let's write at least one simple test for the Query RPC.
Contributor
Author
|
Merged queries and added basic tests. Note that PR is now proto-breaking (only for the |
robert-zaremba
approved these changes
Jan 4, 2023
Contributor
robert-zaremba
left a comment
There was a problem hiding this comment.
preapproving. As noted in the comment, let's remove the optional flag. According to the proto documentation it doesn't change anything, but makes the implementation a bit more obscure.
This was referenced Apr 19, 2024
Merged
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In addition to the existing historacle-enabled
MaxWithdrawquery, this PR implements the following:MaxBorrowIn addition, the
Denomfield in those queries is now optional, and they returnsdk.Coinsinstead ofsdk.Coin. If denom is not specified, calculates max borrow/withdraw for ALL registered tokens.See proto file for query urls and data types.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...