feat!: Add medians param to Token struct#1685
Merged
adamewozniak merged 7 commits intomainfrom Jan 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
=======================================
Coverage 57.97% 57.97%
=======================================
Files 73 73
Lines 7821 7821
=======================================
Hits 4534 4534
Misses 2934 2934
Partials 353 353
|
adamewozniak
approved these changes
Jan 5, 2023
Collaborator
adamewozniak
left a comment
There was a problem hiding this comment.
this lgtm! this will change the leverage registry query response. let's get another review on here too
cc: @EbrahimUmee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional testing is needed to make sure this doesn't break mainnet state, old governance (containing
Tokenstruct), etc.See the PR #1689 liked for one optimistic test and some more notes.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...