fix: Enforce voting threshold param in oracle endblocker#1707
Merged
rbajollari merged 11 commits intomainfrom Feb 7, 2023
Merged
fix: Enforce voting threshold param in oracle endblocker#1707rbajollari merged 11 commits intomainfrom
rbajollari merged 11 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
robert-zaremba
left a comment
robert-zaremba
left a comment
There was a problem hiding this comment.
So we are ignoring an update and will have updated price? We need some notification about that.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1707 +/- ##
==========================================
+ Coverage 57.83% 57.85% +0.02%
==========================================
Files 78 78
Lines 8013 8017 +4
==========================================
+ Hits 4634 4638 +4
Misses 3043 3043
Partials 336 336
|
adamewozniak
approved these changes
Feb 6, 2023
Collaborator
adamewozniak
left a comment
adamewozniak
left a comment
There was a problem hiding this comment.
pre-approving with a couple comments 👍
17 tasks
Contributor
|
@Mergifyio backport release.v4.1.x |
Contributor
❌ No backport have been createdDetails
|
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
* Enforce vote threshold in oracle endblocker * Add logging * Fix conflict issues * pr comments --------- Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> (cherry picked from commit 852ff39) # Conflicts: # x/oracle/abci.go
toteki
added a commit
that referenced
this pull request
Feb 14, 2023
) (#1816) * fix: Enforce voting threshold param in oracle endblocker (#1707) * Enforce vote threshold in oracle endblocker * Add logging * Fix conflict issues * pr comments --------- Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> (cherry picked from commit 852ff39) # Conflicts: # x/oracle/abci.go * remove conflict * lint++ * func-- * Revert * fix merge * lint++ --------- Co-authored-by: ryanbajollari <54822716+rbajollari@users.noreply.github.com> Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When updating the oracle rewarding in Ojo we noticed that the param
VoteThresholdwas not being used to enforce a minimum percentage of votes for a ballot to pass. This PR adds that enforcement and a unit test for it.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...