Skip to content

feat: add blockNum to median and median deviation queries#1717

Merged
zarazan merged 6 commits intomainfrom
zarazan/prices-blocknum
Jan 17, 2023
Merged

feat: add blockNum to median and median deviation queries#1717
zarazan merged 6 commits intomainfrom
zarazan/prices-blocknum

Conversation

@zarazan
Copy link
Copy Markdown
Contributor

@zarazan zarazan commented Jan 16, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zarazan zarazan force-pushed the zarazan/prices-blocknum branch from 794e76b to 6b2581c Compare January 17, 2023 18:43
@zarazan zarazan marked this pull request as ready for review January 17, 2023 19:02
@zarazan zarazan requested review from a team as code owners January 17, 2023 19:02
Copy link
Copy Markdown
Collaborator

@rbajollari rbajollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zarazan zarazan merged commit a7f86d1 into main Jan 17, 2023
@zarazan zarazan deleted the zarazan/prices-blocknum branch January 17, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants