Merged
Conversation
toteki
added
T:Bug
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1807 +/- ##
==========================================
- Coverage 57.80% 57.62% -0.19%
==========================================
Files 78 79 +1
Lines 8023 8049 +26
==========================================
Hits 4638 4638
- Misses 3047 3073 +26
Partials 338 338
|
gsk967
requested changes
Feb 13, 2023
Collaborator
gsk967
left a comment
gsk967
left a comment
There was a problem hiding this comment.
Can you check the error code and github lints
Contributor
robert-zaremba
left a comment
robert-zaremba
left a comment
There was a problem hiding this comment.
We should avoid growing the keeper package.
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom. (cherry picked from commit 0e4df51) # Conflicts: # app/upgrades.go # x/leverage/keeper/internal_test.go
toteki
added a commit
that referenced
this pull request
Feb 14, 2023
* fix: 4.1 BNB migration (#1807) This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom. (cherry picked from commit 0e4df51) # Conflicts: # app/upgrades.go # x/leverage/keeper/internal_test.go * fix conficts --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This was referenced Apr 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will switch the BNB ibc denom in the leverage registry and oracle accept list to the correct denom.