feat: automatically clear unsupplied blacklisted tokens#1808
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1808 +/- ##
==========================================
- Coverage 57.80% 57.72% -0.09%
==========================================
Files 78 78
Lines 8023 8044 +21
==========================================
+ Hits 4638 4643 +5
- Misses 3047 3061 +14
- Partials 338 340 +2
|
robert-zaremba
suggested changes
Feb 13, 2023
Collaborator
adamewozniak
left a comment
adamewozniak
left a comment
There was a problem hiding this comment.
Might want to make this a bit more clear on the proposal side.
Let's add something like an "AttemptDelete" flag
robert-zaremba
approved these changes
Feb 14, 2023
Contributor
robert-zaremba
left a comment
robert-zaremba
left a comment
There was a problem hiding this comment.
Pre-approving. Added one small request in the thread
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
* feat: automatically clear unsupplied blacklisted tokens * cl++ * add oracle hooks call * lint++ * README++ --------- Co-authored-by: Robert Zaremba <robert@zaremba.ch> (cherry picked from commit 614d2c5)
toteki
added a commit
that referenced
this pull request
Feb 14, 2023
* feat: automatically clear unsupplied blacklisted tokens * cl++ * add oracle hooks call * lint++ * README++ --------- Co-authored-by: Robert Zaremba <robert@zaremba.ch> (cherry picked from commit 614d2c5) Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a leverage registry update passes (regardless of whether it blacklisted any tokens), the module checks for any existing blacklisted tokens with zero supply and deletes them.
If supply is nonzero, deletion is not acceptable because the module would lose the ability to interpret existing uToken balances, reserves, borrows, etc for the blacklisted base denom.