fix(oracle): power vote calculation#1852
Merged
robert-zaremba merged 14 commits intomainfrom Feb 20, 2023
Merged
Conversation
toteki
reviewed
Feb 20, 2023
Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com>
toteki
reviewed
Feb 20, 2023
toteki
reviewed
Feb 20, 2023
toteki
reviewed
Feb 20, 2023
toteki
reviewed
Feb 20, 2023
toteki
reviewed
Feb 20, 2023
toteki
approved these changes
Feb 20, 2023
Contributor
toteki
left a comment
toteki
left a comment
There was a problem hiding this comment.
Pushed some changes:
- fix simulations
- updates some comments
- combine two for loops with identical iterations
Looks good from my side as soon as test pass - might want to wait for another review from woz before resolving the final conversation
rbajollari
reviewed
Feb 20, 2023
rbajollari
approved these changes
Feb 20, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1852 +/- ##
==========================================
- Coverage 56.95% 56.91% -0.04%
==========================================
Files 93 93
Lines 8797 8803 +6
==========================================
Hits 5010 5010
- Misses 3422 3428 +6
Partials 365 365
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
* fix(oracle): power vote calculation * finish test * oracle: add SetVoteThreshold method * more VoteThreshold tests * lint * cleanup * Update x/oracle/types/params.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * comment changes only (review) * combine loops * fix simulations * fix error test * fix sims? * review --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> (cherry picked from commit 76fc6f1)
robert-zaremba
added a commit
that referenced
this pull request
Feb 21, 2023
* fix(oracle): power vote calculation * finish test * oracle: add SetVoteThreshold method * more VoteThreshold tests * lint * cleanup * Update x/oracle/types/params.go Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> * comment changes only (review) * combine loops * fix simulations * fix error test * fix sims? * review --------- Co-authored-by: Adam Moser <63419657+toteki@users.noreply.github.com> (cherry picked from commit 76fc6f1) Co-authored-by: Robert Zaremba <robert@zaremba.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes power vote calculation in the oracle end blocker.
#1845 partially handles that, but in fact introduces a bug.