chore(uibc): update quota -> outflows#1865
Merged
robert-zaremba merged 5 commits intomainfrom Feb 23, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1865 +/- ##
=======================================
Coverage 56.07% 56.07%
=======================================
Files 93 93
Lines 8803 8802 -1
=======================================
Hits 4936 4936
+ Misses 3502 3501 -1
Partials 365 365
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if quotaExpires == nil || quotaExpires.Before(ctx.BlockTime()) { | ||
| util.Panic(keeper.ResetQuota(ctx)) | ||
| util.Panic(keeper.ResetAllQuotas(ctx)) | ||
| } |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| if quotaExpires == nil || quotaExpires.Before(ctx.BlockTime()) { | ||
| util.Panic(keeper.ResetQuota(ctx)) | ||
| util.Panic(keeper.ResetAllQuotas(ctx)) | ||
| } |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
gsk967
requested changes
Feb 22, 2023
Contributor
Author
|
@gsk967 you should not block a PR if your suggestions are only about updating code comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description