Skip to content

feat: integrate ICA#1963

Merged
robert-zaremba merged 4 commits intomainfrom
robert/ica
Mar 30, 2023
Merged

feat: integrate ICA#1963
robert-zaremba merged 4 commits intomainfrom
robert/ica

Conversation

@robert-zaremba
Copy link
Copy Markdown
Contributor

Description

  • Integrates IBC ICA Host stack.
  • also added few comments for IBC fee integration for the future.

@robert-zaremba robert-zaremba requested a review from a team as a code owner March 30, 2023 14:09
Base automatically changed from robert/bump-ibc to main March 30, 2023 14:19
@github-actions github-actions bot requested a review from a team as a code owner March 30, 2023 14:19
Copy link
Copy Markdown
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to build and run the binary in local it is not running,
We need to add icahosttypes.StoreKey in storeKeys

Copy link
Copy Markdown
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-zaremba robert-zaremba added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit 89ee005 Mar 30, 2023
@robert-zaremba robert-zaremba deleted the robert/ica branch March 30, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants