fix: allow collateral weight = liquidation threshold#2052
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2052 +/- ##
==========================================
- Coverage 75.38% 70.49% -4.90%
==========================================
Files 100 126 +26
Lines 8025 9605 +1580
==========================================
+ Hits 6050 6771 +721
- Misses 1589 2367 +778
- Partials 386 467 +81
|
robert-zaremba
approved these changes
May 18, 2023
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously #1956 prevented this, but this has made tokens with
collateral weight = liquidation threshold = 0invalid, including some in the existing mainnet registry.