Skip to content

fix: MsgSupplyCollateral and MinCollateralLiquidity#2089

Merged
toteki merged 2 commits intomainfrom
adam/patch
Jun 8, 2023
Merged

fix: MsgSupplyCollateral and MinCollateralLiquidity#2089
toteki merged 2 commits intomainfrom
adam/patch

Conversation

@toteki
Copy link
Copy Markdown
Contributor

@toteki toteki commented Jun 8, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@toteki toteki requested review from a team as code owners June 8, 2023 09:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2089 (d45a2e9) into main (7f05ad4) will decrease coverage by 4.79%.
The diff coverage is 60.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   75.38%   70.60%   -4.79%     
==========================================
  Files         100      126      +26     
  Lines        8025     9577    +1552     
==========================================
+ Hits         6050     6762     +712     
- Misses       1589     2350     +761     
- Partials      386      465      +79     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
util/store/unmarshal.go 0.00% <0.00%> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/hooks.go 0.00% <0.00%> (ø)
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/incentive/keeper/keeper.go 64.28% <ø> (ø)
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
x/leverage/keeper/grpc_query.go 67.21% <ø> (ø)
... and 74 more

... and 19 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. Please add a test to clarify the fix. Can be in a subsequent release.

@toteki toteki added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit fcf924c Jun 8, 2023
@toteki toteki deleted the adam/patch branch June 8, 2023 14:51
robert-zaremba pushed a commit that referenced this pull request Jun 8, 2023
* fix: MsgSupplyCollateral and MinCollateralLiquidity

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants