Conversation
Codecov Report
@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
- Coverage 75.38% 74.61% -0.78%
==========================================
Files 100 127 +27
Lines 8025 9805 +1780
==========================================
+ Hits 6050 7316 +1266
- Misses 1589 2004 +415
- Partials 386 485 +99
|
gsk967
approved these changes
Jun 21, 2023
robert-zaremba
approved these changes
Jun 21, 2023
Contributor
robert-zaremba
left a comment
robert-zaremba
left a comment
There was a problem hiding this comment.
LGTM. Pre-approving.
- I would prefer to discuss a different name for the rpc method (see the comment)
- changelog update is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proto (and scaffolding around generated framework) only in this PR.