test: increase x/oracle unit test coverage#786
Merged
RafilxTenfen merged 15 commits intomainfrom Apr 11, 2022
Merged
Conversation
RafilxTenfen
changed the title
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
==========================================
+ Coverage 48.03% 49.77% +1.74%
==========================================
Files 64 64
Lines 9329 9426 +97
==========================================
+ Hits 4481 4692 +211
+ Misses 4581 4486 -95
+ Partials 267 248 -19
|
18 tasks
…e into rafilx/test/oracle-grpc
…mee into rafilx/test/oracle-grpc
18 tasks
adamewozniak
changed the title
Collaborator
adamewozniak
left a comment
adamewozniak
left a comment
There was a problem hiding this comment.
Just some code cleanliness stuff 😄
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
adamewozniak
approved these changes
Apr 11, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2022
* add empty request test * add unit test for grpc_query_test * add missing tests to grpc * add str tests for oracle vote * add #786 to changelog * add changelog to 788 * add unit tests to oracle-params * add changelog to 789 * update tests, comments and rename Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> * modified tests to be more readable * update unit tests to use testSuite Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> (cherry picked from commit f0389b7)
adamewozniak
pushed a commit
that referenced
this pull request
Apr 11, 2022
* add empty request test * add unit test for grpc_query_test * add missing tests to grpc * add str tests for oracle vote * add #786 to changelog * add changelog to 788 * add unit tests to oracle-params * add changelog to 789 * update tests, comments and rename Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> * modified tests to be more readable * update unit tests to use testSuite Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com> (cherry picked from commit f0389b7) Co-authored-by: Rafael Tenfen <rafaeltenfen.rt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
x/oracle/keeper/grpc_query.gox/oracle/types/params_test.gox/oracle/types/vote_test.gohelps: #661
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change