Conversation
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
==========================================
- Coverage 51.08% 51.04% -0.05%
==========================================
Files 64 64
Lines 9425 9431 +6
==========================================
- Hits 4815 4814 -1
- Misses 4365 4372 +7
Partials 245 245
|
| string oracle_price = 3 | ||
| [(gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec", (gogoproto.nullable) = true]; |
There was a problem hiding this comment.
Note how nullable is true here - if oracle is down, this field will be null but the query will work.
| string market_size = 7 | ||
| [(gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Int", (gogoproto.nullable) = false]; |
There was a problem hiding this comment.
Note market_size (tokens) not market_size_usd here. See discussion question in PR description
|
This is the assets USD price (double check with core dev)
Yes wont make any difference on the front end. |
|
It's correct - the 10^6 difference is between |
* feat: add MarketSummary query (cherry picked from commit 0ecf33c) # Conflicts: # x/leverage/types/query.pb.go # x/leverage/types/query.pb.gw.go

Description
Adds a query which groups a set of queries the frontend often executes together.
Needs discussion:
exchange_raterequested in client #434 refer to asset's USD price (x/oraclequery) or its uToken exchange rate (x/leveragequery)? Currently returns both.5M ATOMinstead of usd market size (e.g.100M USD)? Frontend would then multiple by oracle price.closes: #893
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change