Conversation
Bumps [stylelint-config-sass-guidelines](https://github.com/bjankord/stylelint-config-sass-guidelines) from 10.0.0 to 12.1.0. - [Release notes](https://github.com/bjankord/stylelint-config-sass-guidelines/releases) - [Changelog](https://github.com/bjankord/stylelint-config-sass-guidelines/blob/main/CHANGELOG.md) - [Commits](bjankord/stylelint-config-sass-guidelines@v10.0.0...v12.1.0) --- updated-dependencies: - dependency-name: stylelint-config-sass-guidelines dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.96.1 to 5.97.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.96.1...v5.97.1) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 9.18.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.1...v9.18.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sass-embedded](https://github.com/sass/embedded-host-node) from 1.81.0 to 1.83.4. - [Changelog](https://github.com/sass/embedded-host-node/blob/main/CHANGELOG.md) - [Commits](sass/embedded-host-node@1.81.0...1.83.4) --- updated-dependencies: - dependency-name: sass-embedded dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [stylelint-config-standard](https://github.com/stylelint/stylelint-config-standard) from 34.0.0 to 37.0.0. - [Release notes](https://github.com/stylelint/stylelint-config-standard/releases) - [Changelog](https://github.com/stylelint/stylelint-config-standard/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint-config-standard@34.0.0...37.0.0) --- updated-dependencies: - dependency-name: stylelint-config-standard dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…rd-37.0.0' into dependencies-upgrade-27-01-2025
…endencies-upgrade-27-01-2025
…uidelines-12.1.0' into dependencies-upgrade-27-01-2025
…pendencies-upgrade-27-01-2025
Dependencies upgrade 27 01 2025
…ordin with npm run build
…-multiple-drawers-opened-on-load #1460 Enhance is-active behavior & optimize multi-expand logic in ac…
…ed-in-rtl-layout #1500 - Fix arrow position in RTL mode
…follow-current-layout-settings #1501 - added RTL hover animation for links
Added new chevron colors
Contributor
There was a problem hiding this comment.
PR Overview
This PR for Release 1.3.10 improves the formatting and readability of the Accordion component and its story, while also refactoring the JS module for better clarity. Key changes include:
- Updated multi-line formatting of text and JSX in Accordion stories for enhanced legibility.
- Refactored JSX formatting in the Accordion component to use consistent indentation.
- Improved the formatting and function signature in the accordion JS file, with a potential typo correction opportunity.
Reviewed Changes
| File | Description |
|---|---|
| stories/Components/UIcomponents/Accordion/Accordion.stories.js | Reformatted text and JSX structure for enhanced readability |
| stories/Components/UIcomponents/Accordion/Accordion.jsx | Standardized JSX indentation and consistent code style |
| stories/assets/js/accordion.js | Refactored code formatting and function signature; potential naming typo noted |
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Deploying design-system with
|
| Latest commit: |
72b0f4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5b10f99.design-system.pages.dev |
| Branch Preview URL: | https://develop.design-system.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.