Update the changelog in the preversion hook, avoiding an extra commit - #613
Merged
Merged
Conversation
sunesimonsen
approved these changes
Mar 31, 2019
sunesimonsen
left a comment
sunesimonsen
left a comment
Member
There was a problem hiding this comment.
This to a really nice improvement.
Member
|
Love this! |
joelmukuthu
reviewed
Apr 3, 2019
| "generate-site": "generate-site --require ./bootstrap-unexpected-markdown.js", | ||
| "update-examples": "generate-site --require ./bootstrap-unexpected-markdown.js --update-examples", | ||
| "preversion": "test -n \"${IS_MAKE_RELEASE}\" || (echo Please run make release instead && exit 1)" | ||
| "preversion": "(test -n \"${IS_MAKE_RELEASE}\" || (echo Please run make release instead && exit 1)) && offline-github-changelog --next=${npm_package_version} > CHANGELOG.md && git add CHANGELOG.md" |
Member
There was a problem hiding this comment.
@papandreou FYI https://npm.community/t/npm-version-preversion-npm-package-version/1406 && npm/cli#51. This might fail from npm 7
Member
Author
There was a problem hiding this comment.
Ah, thanks. I guess we should switch to version, then?
Member
There was a problem hiding this comment.
Yes, it seems to fit this use case 🙂
papandreou
added a commit
that referenced
this pull request
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
offline-github-changelog's new--nextfeature and @gustavnikolaj's${npm_package_version}trick 😎