ICU-22813 Rise the size of the buffers used for the command strings at pkgdata#3058
Merged
Merged
Conversation
…t pkgdata The tool pkgdata uses snprintf() to build the strings of the commands that will execute later during the install process. But the maximum size of this buffers is not enough when there is a long path. This has caused issues on some CI systems that use very long paths, causing the install process to produce a wrong result. The maximum path on Linux is 4096 (defined as PATH_MAX at <linux/limits.h>) So the size of SMALL_BUFFER_MAX_SIZE should be 4096 to avoid errors related to truncated paths.
|
|
markusicu
approved these changes
Jul 18, 2024
markusicu
left a comment
markusicu
left a comment
Member
There was a problem hiding this comment.
lgtm tnx!
Longer-term, we should rewrite this kind of code to print into a std::string, which we can use here since it's not part of the ICU runtime libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool pkgdata uses snprintf() to build the strings of the commands that will execute later during the install process. But the maximum size of this buffers is not enough when there is a long path.
This has caused issues on some CI systems that use very long paths, causing the install process to produce a wrong result.
The maximum path on Linux is 4096 (defined as PATH_MAX at <linux/limits.h>) So the size of SMALL_BUFFER_MAX_SIZE should be 4096 to avoid errors related to truncated paths.
Checklist