Skip to content

MAINT Fixes for Python scripts#54

Merged
Manishearth merged 3 commits into
unicode-rs:masterfrom
rth:py-impr
May 15, 2019
Merged

MAINT Fixes for Python scripts#54
Manishearth merged 3 commits into
unicode-rs:masterfrom
rth:py-impr

Conversation

@rth

@rth rth commented May 15, 2019

Copy link
Copy Markdown
Contributor

A few fixes to python scripts,

  • add Python 3 support (Python 2 is deprecated at the end of the year), Python2 will still work. The main difference comes from the fact that,
    $ python2 -c "print(len('×'))"
    2
    $ python3 -c "print(len('×'))"                               
    1
  • fix invalid escape characters in strings e.g. "\w" -> r"\w"
  • fix the download URL to get Unicode 9.0 used here, otherwise data for Unicode 12 is downloaded as mentioned in Unicode sentence boundaries #24 (review)

I double checked that these scripts generate the included tables.rs and testdata.rs both with Python 2 and 3

@rth rth changed the title MAINT Fixes for Python scipts MAINT Fixes for Python scripts May 15, 2019
@Manishearth

Copy link
Copy Markdown
Member

Looks good, needs conflicts to be resolved

@Manishearth Manishearth merged commit 7cb6dca into unicode-rs:master May 15, 2019
@Manishearth

Copy link
Copy Markdown
Member

Thanks!

@rth rth deleted the py-impr branch May 15, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants