feat(image): split logic into "fill" and "default" variants with fallback size resolution#148
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MichaelLonin
approved these changes
Jun 18, 2025
eugeneshulga869
changed the title
trsergey25
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Image component logic to support two distinct variants:
Changes:
• Split image rendering logic into:
• "fill" variant — image takes size from the parent container.
• "default" variant — requires explicit image dimensions.
• Primary image dimensions now come from Uniform assets (resolvedImage.width/height).
• Fallback logic added using probe-image-size to retrieve image size by URL when no size metadata is available.
• Focal point support integrated (used in image transformation).
Implementation Notes:
• probe-image-size is used only when dimensions are missing from the asset.
• No impact on public API – backward compatible.