Check for !== undefined to avoid treating false as not resolved#189
Merged
Merged
Conversation
|
@piemonkey is attempting to deploy a commit to the universal-ember Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
NullVoxPopuli
approved these changes
Apr 22, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across an issue with
trackedFunctionwrapping a function that returnsPromise<boolean>. TheStateclass'state()getter and theisResolved()method were both mistakenly treating a falsy value as 'not resolved'. Since the internals returnundefinedbefore the promise resolves, I replaced the logic with a!== undefinedcheck. This would still fail if the wrapped function returnsPromise<truthy | undefined>, but at least this handlesfalseornulland does not modify any other behaviour.