Open
Conversation
readPackage's try option support
readPackage's try option supporttry option support
try option supporttry option
try optiontry option for all utils
pi0
reviewed
Feb 16, 2026
| * | ||
| * @default false | ||
| */ | ||
| try?: boolean; |
Member
There was a problem hiding this comment.
I'm feeling maybe we should call it tryResolve, as calls can throw error if reading (permissions) or parsing (malformed) errors happen.
Author
There was a problem hiding this comment.
For the functions in resolve/utils.ts there is no problem in renaming to tryResolve. But should the findPackage, readPackage, and updatePackage functions keep their try option (extended from exsolve's ResolveOptions)? When calling utils from those functions, options could be transformed like this: { ...options, tryResolve: options.try }. Other alternative would be to Omit try and replace with tryResolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #257
MaybeTryutility type to resolve return type of functions that accepttry.trysupport forfindFile(required so that functions usingfindFilemay also suppress errors),findNearestFile, andfindFarthestFile.trysupport forfindPackage,readPackage, andupdatePackage.readPackagetest for returningundefinedinstead of throwing error withtry: true.