fix: use untransformed typescript type exports#261
Conversation
| @@ -0,0 +1,3 @@ | |||
| import type ts from "typescript"; | |||
There was a problem hiding this comment.
Could we instead, uptate src/tsconfig to do non named import?
Testing this, it remains as-is in dist/.dts
import type * as ts from "typescript";
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughRefactors TypeScript type imports in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
spotted that rollup has difficulty with named exports from
typescript, but this syntax seems to workthis is the error we get:
if it seems off to you in any way, please feel free to ignore! 🙏
Summary by CodeRabbit
Refactor
Chores