Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix: multiple ce instances styles tracking#114

Merged
baiwusanyu-c merged 2 commits intounplugin:masterfrom
OBe95:multiple-ce-instances-style
Nov 27, 2023
Merged

fix: multiple ce instances styles tracking#114
baiwusanyu-c merged 2 commits intounplugin:masterfrom
OBe95:multiple-ce-instances-style

Conversation

@OBe95
Copy link
Copy Markdown

@OBe95 OBe95 commented Nov 21, 2023

Description

close #113
Removing the 1st CE instance of a v-for, leads to style being completely removed from the DOM even though there are still other CEs relying on it

This seems to be linked to the optimisation done in this PR to avoid appending the same style multiple time

Linked Issues

Additional context

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@OBe95 OBe95 force-pushed the multiple-ce-instances-style branch from 4b1331d to 96cc198 Compare November 21, 2023 15:59
@OBe95 OBe95 changed the title fix multiple ce instances styles tracking fix: multiple ce instances styles tracking Nov 21, 2023
@baiwusanyu-c baiwusanyu-c merged commit d3453e9 into unplugin:master Nov 27, 2023
@baiwusanyu-c baiwusanyu-c linked an issue Nov 27, 2023 that may be closed by this pull request
3 tasks
@OBe95 OBe95 deleted the multiple-ce-instances-style branch November 27, 2023 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - CE component styles are removed too early when using Transition [BUG] - Multiple CE instances style breaking when 1st CE removed from the DOM

2 participants