Skip to content

feat: fix shading in UPC to be less severe #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elibosley merged 2 commits into from
Jun 25, 2025
Merged

feat: fix shading in UPC to be less severe #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73b6e2
feat: fix shading in UPC to be less severe
elibosley Jun 25, 2025
c404dc0
chore: fix unit tests
elibosley Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions web/__test__/store/theme.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,15 @@ describe('Theme Store', () => {
banner: true,
bannerGradient: true,
});
expect(store.bannerGradient).toBe(
'background-image: linear-gradient(90deg, rgba(0, 0, 0, 0) 0, var(--header-background-color) 30%);'
);
expect(store.bannerGradient).toMatchInlineSnapshot(`"background-image: linear-gradient(90deg, rgba(0, 0, 0, 0) 0, var(--header-background-color) 90%);"`);

store.setTheme({
...store.theme,
banner: true,
bannerGradient: true,
bgColor: '#123456',
});
expect(store.bannerGradient).toBe(
'background-image: linear-gradient(90deg, var(--header-gradient-start) 0, var(--header-gradient-end) 30%);'
);
expect(store.bannerGradient).toMatchInlineSnapshot(`"background-image: linear-gradient(90deg, var(--header-gradient-start) 0, var(--header-gradient-end) 90%);"`);
});
});

Expand Down
2 changes: 1 addition & 1 deletion web/components/UserProfile.ce.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ onMounted(() => {
>
<div
v-if="bannerGradient"
class="absolute z-0 w-[125%] top-0 bottom-0 right-0"
class="absolute z-0 w-full top-0 bottom-0 right-0"
:style="bannerGradient"
/>

Expand Down
4 changes: 2 additions & 2 deletions web/store/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const useThemeStore = defineStore('theme', () => {
}
const start = theme.value?.bgColor ? 'var(--header-gradient-start)' : 'rgba(0, 0, 0, 0)';
const end = theme.value?.bgColor ? 'var(--header-gradient-end)' : 'var(--header-background-color)';
return `background-image: linear-gradient(90deg, ${start} 0, ${end} 30%);`;
return `background-image: linear-gradient(90deg, ${start} 0, ${end} 90%);`;
});
// Actions
const setTheme = async (data?: Theme) => {
Expand Down Expand Up @@ -110,7 +110,7 @@ export const useThemeStore = defineStore('theme', () => {
: customTheme['--header-gradient-end'];

// set the banner gradient
customTheme['--banner-gradient'] = `linear-gradient(90deg, ${start} 0, ${end} 30%)`;
customTheme['--banner-gradient'] = `linear-gradient(90deg, ${start} 0, ${end} 90%)`;
}

// overwrite with hex colors set in webGUI @ /Settings/DisplaySettings
Expand Down
Loading