Skip to content

Update VM Text Items#2060

Merged
limetech merged 6 commits into
unraid:masterfrom
SimonFair:VM-Manager-PHP-Fixes
Mar 10, 2025
Merged

Update VM Text Items#2060
limetech merged 6 commits into
unraid:masterfrom
SimonFair:VM-Manager-PHP-Fixes

Conversation

@SimonFair

@SimonFair SimonFair commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Style
    • Simplified the VM creation button label by removing extraneous text.
    • Updated CPU-related terminology on configuration forms from "CPU Cores" to "vCPUs" and from "Logical CPUs" to "Pinned Cores".
    • Refined table header labels by changing "CPU:" to "CORES:" and "VPCUS" to "VCPUS".
    • Clarified descriptions regarding logical CPUs and updated selection instructions for vCPU allocation.

@coderabbitai

coderabbitai Bot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This update refines several UI labels in the Virtual Machine Manager module. In the VM Machines page, the "Add VM" button label is simplified by removing the extra "Templates" text. Additionally, CPU configuration labels in both the custom form and the CPU overview page are updated to use revised terminology, such as "vCPUs" and "Pinned Cores" instead of the previous labels. The functionality in all instances remains unchanged.

Changes

Files Change Summary
emhttp/.../VMMachines.page Modified the button label for adding a VM, removing "Templates" to display "Add VM".
emhttp/.../Custom.form.php, emhttp/.../CPUvms.page Updated CPU-related labels: changed "(CPU Cores)" to "(vCPUs)", "(Logical CPUs)" to "(Pinned Cores)", "CPU:" to "CORES:", and "VPCUS" to "VCPUS".

Possibly Related PRs

  • 7.x Various VM Updates #1988: Involved similar UI adjustments for the "Add VM" button label, albeit in an opposite change direction, indicating a direct code-level connection.

Poem

I'm just a rabbit with hops so spry,
Skipping through changes as moments fly.
Button labels trimmed with a twitch of my ear,
CPU words polished, now crystal clear.
Hoppy coding days, full of cheer!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4ab411a and 0de81c7.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • emhttp/plugins/dynamix.vm.manager/templates/Custom.form.php

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@limetech limetech merged commit 32454ba into unraid:master Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants