wlan0: prevent read error when port status is unavailable

[bergware]

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for wireless connection status checks, allowing for a more graceful response when the WiFi status is unavailable.

• New Features

  • Added the ability to enable jumbo frames in the network settings, now featuring an icon for tooltip information.
  • Introduced a checkbox for managing MTU settings, enhanced with an accompanying icon for user guidance.
  • Added configuration output for USE_MTU in the network initialization process.

• Style

  • Updated styles for select elements to improve layout and spacing in the network settings interface.

• Security Enhancements

  • Improved encryption handling for username and password inputs to enhance security during the encryption process.

[coderabbitai]

Walkthrough

The modifications introduce a try-catch block to handle exceptions when checking the status of the wireless connection in the plugin. The original approach directly checked the readability of the $wlan0 file and proceeded to parse the INI file. The new implementation allows for graceful error handling during execution, setting appropriate indicators for WiFi status when exceptions occur. Additionally, the file_get_contents($wlan0) call is now prefixed with an error suppression operator to prevent warnings. The changes also update the network settings interface by replacing title attributes with icons for jumbo frames and modifying the output of the USE_MTU array in the network.ini file.

Changes

File Path	Change Summary
emhttp/plugins/dynamix/nchan/wlan0	Introduced a try-catch block for exception handling during wireless status checks; added error suppression to file_get_contents($wlan0).
emhttp/plugins/dynamix/Eth0.page	Removed title attribute from jumbo frames checkbox; added icon for tooltip information.
emhttp/plugins/dynamix/EthX.page	Removed title attribute from USE_MTU checkbox; added icon for tooltip information with multi-line string.
emhttp/plugins/dynamix/sheets/Eth0.css	Added new style rule select.ctrl with margin-right: 20px.
sbin/create_network_ini	Added line to output USE_MTU value for each network interface in the network.ini file.
emhttp/plugins/dynamix/include/update.wireless.php	Updated encryption method for username and password inputs to enhance security against command injection.

Possibly related PRs

• Wireless: add wifi info to dashboard and info button #2038: Related changes involve enhancing error handling for wireless connection status, similar to modifications in this PR.
• Wireless support - fine tuning #2002: Enhancements to network interface handling, including wireless interfaces, are connected to the error handling introduced in this PR.

Poem

🐇 In the code, a gentle catch,
To handle errors, we now hatch.
With a hop and a skip, we check the file,
Graceful flows make coding worthwhile.
A rabbit’s joy in every line,
As wireless wonders brightly shine!
🌟 Let’s leap through code, it’s simply divine!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 3fab0ca and 607a73e.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/update.wireless.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• emhttp/plugins/dynamix/include/update.wireless.php

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32454ba and 4a8ff20.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/nchan/wlan0 (1 hunks)

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

emhttp/plugins/dynamix/include/update.wireless.php (1)

17-18: Great security improvement for command execution!

The addition of str_replace('$','\$',...) properly escapes dollar signs in usernames and passwords before they're passed to the encryption command. This prevents potential command injection issues where unescaped dollar signs could lead to unexpected shell variable interpolation.

Consider adding error handling for the exec() call to gracefully handle any encryption failures:

-if (!empty($_POST['USERNAME'])) $_POST['USERNAME'] = exec("$open_ssl encrypt \"".str_replace('$','\$',$_POST['USERNAME'])."\"");
+if (!empty($_POST['USERNAME'])) {
+    $encrypted = exec("$open_ssl encrypt \"".str_replace('$','\$',$_POST['USERNAME'])."\"", $output, $return_code);
+    $_POST['USERNAME'] = ($return_code === 0) ? $encrypted : $_POST['USERNAME'];
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 689e27f and 3fab0ca.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/update.wireless.php (1 hunks)