Diagnostics: remove wireless username/password from diagnostics

[bergware]

Summary by CodeRabbit

• New Features

  • Improved diagnostic processing now automatically masks sensitive details. Sensitive user credentials are replaced with a placeholder to help protect privacy during diagnostics.
  • Wireless configuration details are also sanitized when present, ensuring that exposed credentials in diagnostic outputs are securely anonymized.

• Enhancements

  • Updated logic for Docker network settings to improve configuration handling.
  • Enhanced clarity and readability of code related to DHCP settings and network configuration.
  • Added logic to ensure correct regulatory domain settings based on country codes when establishing WiFi connections.

[coderabbitai]

Walkthrough

The changes enhance the functionality of the diagnostics script by improving the anonymize function. A new regular expression replaces occurrences of USERNAME and PASSWORD with "removed" in the processed text. Additionally, the script checks for the existence of a wireless.cfg file and anonymizes its sensitive entries if present. Modifications to the DockerSettings.page file focus on Docker network settings logic and formatting adjustments, while the docker_network_start function in rc.docker introduces conditional checks for network address assignments. The wifi_join function in rc.wireless now includes logic for handling country code settings upon WiFi connection establishment. No changes were made to exported or public interfaces.

Changes

File Path	Change Summary
emhttp/plugins/dynamix/scripts/diagnostics/*	Updated anonymize function to replace USERNAME/PASSWORD with "removed" via regex. Added conditional block to check for wireless.cfg and anonymize its credentials.
emhttp/plugins/dynamix.docker.manager/DockerSettings.page	Updated logic for $auto variable in IPv4/IPv6 sections, modified checkbox onchange attributes for formatting, refactored changeEdit function, and made minor formatting adjustments.
etc/rc.d/rc.docker	Modified docker_network_start function to include conditional checks for assigning IPV4 and IPV6 based on the state of the AUTO variable.
etc/rc.d/rc.wireless	Enhanced wifi_join function to include logic for handling country code settings when establishing a WiFi connection.

Sequence Diagram(s)

sequenceDiagram
    participant DS as Diagnostics Script
    participant AF as Anonymize Function
    participant FS as File System

    DS->>AF: Process input text
    AF-->>DS: Return text with sensitive data replaced
    DS->>FS: Check if "wireless.cfg" exists
    alt wireless.cfg exists
        FS-->>DS: File found
        DS->>AF: Anonymize "USERNAME"/"PASSWORD" entries in wireless.cfg
        AF-->>DS: Return anonymized file content
    else File not found
        FS-->>DS: Return file not found
    end

Loading

Poem

Hopping through lines of code under the moonlit night,
I hide your secrets with a swift and gentle bite.
Sensitive keys now vanish from the view,
"Removed" whispers softly, safe and true.
In my burrow of bytes, your data stays light.
Cheers from this clever rabbit, coding with delight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between a127aca and a600dbc.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/scripts/diagnostics (11 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• emhttp/plugins/dynamix/scripts/diagnostics

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.