Wireless: code update

[bergware]

Summary by CodeRabbit

• New Features

  • Enhanced WiFi scanning now displays trimmed MAC addresses for improved accuracy.

• Style

  • Refined the display of network link information for a cleaner, more consistent view.
  • Improved overall formatting for better readability and consistency in network details.
  • Adjusted spacing around operators for better code clarity.

[coderabbitai]

Walkthrough

This pull request includes code formatting changes and minor functional adjustments to two plugin files. In NetworkInfo.php, whitespace adjustments improve readability, the field count in the wireless link information command is reduced from five to four, and a new line sorts the band array. In Wireless.php, a substring extraction for MAC addresses is introduced in the Wi-Fi scan function, and additional spacing corrections are applied in the attribute-saving logic. No public API changes were made.

Changes

File(s)	Summary of Changes
emhttp/.../NetworkInfo.php	- Reformatted whitespace in conditions and function calls. - Modified command execution to output 4 fields instead of 5. - Added a sort on the band array.
emhttp/.../Wireless.php	- Added MAC address substring extraction in scanWifi. - Reformatted spacing in conditional checks within the saveAttr function.

Poem

I'm a rabbit in the code glen, hopping light and true,
Nibbling on clean lines and updated views,
From sorted bands to trimmed MAC array,
I hop through functions in a joyful display,
Celebrating code hops with a bounce and a wink too! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between c97b059 and 1878018.

📒 Files selected for processing (1)

• emhttp/plugins/dynamix/include/NetworkInfo.php (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• emhttp/plugins/dynamix/include/NetworkInfo.php

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc264d7 and c97b059.

📒 Files selected for processing (2)

• emhttp/plugins/dynamix/include/NetworkInfo.php (3 hunks)
• emhttp/plugins/dynamix/include/Wireless.php (3 hunks)

🔇 Additional comments (7)

emhttp/plugins/dynamix/include/Wireless.php (3)

48-49: MAC address extraction added.

The added code correctly extracts only the MAC address (17 characters) from the BSS line of the Wi-Fi scan output, improving data consistency.

---

140-143: Formatting improvements for better readability.

Code formatting has been standardized by adding spaces around comparison operators, which improves readability without changing functionality.

---

162-167: Consistent spacing around operators.

Code formatting has been standardized by adding spaces around comparison and ternary operators, which improves readability.

emhttp/plugins/dynamix/include/NetworkInfo.php (4)

25-26: Standardized spacing in conditional checks.

Added consistent spacing around operators and in function arguments, which improves code readability.

---

41-41: Consistent formatting for DNS filtering conditions.

Standardized spacing around comparison operators in the array filter functions, making the code more readable.

Also applies to: 47-47

---

55-59: Added consistent spacing in explode function calls.

Improved code readability by adding spaces after commas in the explode function calls.

---

73-73: Added sorting of wireless bands.

Sorting the band array provides a consistent display order of wireless bands (2.4G, 5G, 6G), improving user experience.